Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: abi output path #198

Merged
merged 8 commits into from
Dec 8, 2023
Merged

fix: abi output path #198

merged 8 commits into from
Dec 8, 2023

Conversation

noyyyy
Copy link
Member

@noyyyy noyyyy commented Dec 7, 2023

No description provided.

@aLIEzsss4
Copy link
Collaborator

"build": "pnpm run build:mud && pnpm run build:abi && pnpm run build:abi-ts",
"build:abi": "rimraf abi && forge build --extra-output-files abi --out abi --skip test script MudTest.sol",
"build:abi-ts": "mud abi-ts --input 'abi/IWorld.sol/IWorld.abi.json' && prettier --write '**/*.abi.json.d.ts'",

The output file is still the abi
Maybe we need to update to the latest version

@noyyyy
Copy link
Member Author

noyyyy commented Dec 7, 2023

"build": "pnpm run build:mud && pnpm run build:abi && pnpm run build:abi-ts",
"build:abi": "rimraf abi && forge build --extra-output-files abi --out abi --skip test script MudTest.sol",
"build:abi-ts": "mud abi-ts --input 'abi/IWorld.sol/IWorld.abi.json' && prettier --write '**/*.abi.json.d.ts'",

The output file is still the abi Maybe we need to update to the latest version

The package is the latest version, but other config is not. We can modify when we need.

@noyyyy
Copy link
Member Author

noyyyy commented Dec 7, 2023

"build": "pnpm run build:mud && pnpm run build:abi && pnpm run build:abi-ts",
"build:abi": "rimraf abi && forge build --extra-output-files abi --out abi --skip test script MudTest.sol",
"build:abi-ts": "mud abi-ts --input 'abi/IWorld.sol/IWorld.abi.json' && prettier --write '**/*.abi.json.d.ts'",

The output file is still the abi Maybe we need to update to the latest version

Fixed it. any other problem?

Copy link

github-actions bot commented Dec 7, 2023

Deploy preview for vercel-autochessia ready!

✅ Preview
https://vercel-autochessia-qvpblvky1-aliez.vercel.app

Built with commit 75c9302.
This pull request is being automatically deployed with vercel-action

@noyyyy noyyyy force-pushed the fix/abi-output-path branch from 75c9302 to 766f8b0 Compare December 7, 2023 10:15
@aLIEzsss4 aLIEzsss4 added this pull request to the merge queue Dec 8, 2023
Merged via the queue into develop with commit 439c3d6 Dec 8, 2023
1 check failed
@aLIEzsss4 aLIEzsss4 deleted the fix/abi-output-path branch December 8, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants