Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade(cli): MUD Version 2.0.0-next.8 #182

Merged
merged 10 commits into from
Sep 24, 2023
Merged

upgrade(cli): MUD Version 2.0.0-next.8 #182

merged 10 commits into from
Sep 24, 2023

Conversation

aLIEzsss4
Copy link
Collaborator

No description provided.

@aLIEzsss4 aLIEzsss4 requested review from noyyyy and ClaudeZsb and removed request for noyyyy September 14, 2023 18:38
@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Deploy preview for vercel-autochessia ready!

✅ Preview
https://vercel-autochessia-m7o1gpe93-aliez.vercel.app

Built with commit b56629d.
This pull request is being automatically deployed with vercel-action

@aLIEzsss4
Copy link
Collaborator Author

The contracts have been split for now, further optimization is needed.

package.json Show resolved Hide resolved
packages/contracts/remappings.txt Outdated Show resolved Hide resolved
packages/indexer/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@noyyyy noyyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@noyyyy
Copy link
Member

noyyyy commented Sep 15, 2023

@aLIEzsss4 aLIEzsss4 requested a review from noyyyy September 15, 2023 10:35
@aLIEzsss4
Copy link
Collaborator Author

This MUD upgrade includes development versions of forge-std and ds-test dependencies. I think we should synchronize with them.

https://github.com/latticexyz/mud/blob/5150544354816949ab3d47950df7fc67ded797a7/examples/minimal/packages/contracts/package.json#L27

or

forge-std/=lib/forge-std/src/
ds-test/=lib/ds-test/src/
@latticexyz/=node_modules/@latticexyz/
@openzeppelin-contracts=lib/openzeppelin-contracts/contracts
cement/=lib/cement/contracts/

@noyyyy
Copy link
Member

noyyyy commented Sep 15, 2023

This MUD upgrade includes development versions of forge-std and ds-test dependencies. I think we should synchronize with them.

https://github.com/latticexyz/mud/blob/5150544354816949ab3d47950df7fc67ded797a7/examples/minimal/packages/contracts/package.json#L27

or

forge-std/=lib/forge-std/src/
ds-test/=lib/ds-test/src/
@latticexyz/=node_modules/@latticexyz/
@openzeppelin-contracts=lib/openzeppelin-contracts/contracts
cement/=lib/cement/contracts/

If you use ssh clone. It will generate lock which cannot be used directly in github action.

If you have used foundry, foundry project mainly use forge install to generate git submodule. By using submodule, you can also assign a commit hash.

Also the forge-std and ds-test are not maintained by lattice. Their api is stable. It usually doesn't matter if you use a different newer version.

@aLIEzsss4
Copy link
Collaborator Author

This MUD upgrade includes development versions of forge-std and ds-test dependencies. I think we should synchronize with them.
https://github.com/latticexyz/mud/blob/5150544354816949ab3d47950df7fc67ded797a7/examples/minimal/packages/contracts/package.json#L27
or

forge-std/=lib/forge-std/src/
ds-test/=lib/ds-test/src/
@latticexyz/=node_modules/@latticexyz/
@openzeppelin-contracts=lib/openzeppelin-contracts/contracts
cement/=lib/cement/contracts/

If you use ssh clone. It will generate lock which cannot be used directly in github action.

If you have used foundry, foundry project mainly use forge install to generate git submodule. By using submodule, you can also assign a commit hash.

Also the forge-std and ds-test are not maintained by lattice. Their api is stable. It usually doesn't matter if you use a different newer version.

fix

Copy link
Member

@noyyyy noyyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will modify indexer things in another pr. Discard these to avoid conflict.

packages/indexer/fly.alt.toml Outdated Show resolved Hide resolved
packages/indexer/fly.lattice.toml Outdated Show resolved Hide resolved
@aLIEzsss4
Copy link
Collaborator Author

I will modify indexer things in another pr. Discard these to avoid conflict.

fix

@aLIEzsss4 aLIEzsss4 requested a review from noyyyy September 22, 2023 18:33
Copy link
Member

@noyyyy noyyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noyyyy
Copy link
Member

noyyyy commented Sep 23, 2023

Let's work together when you're free @aLIEzsss4. We need another indexer change pr to be merged at the same time

@noyyyy
Copy link
Member

noyyyy commented Sep 23, 2023

See #184, but it's wip.

@noyyyy noyyyy added this pull request to the merge queue Sep 24, 2023
Merged via the queue into develop with commit c11e7e2 Sep 24, 2023
@noyyyy noyyyy deleted the upgrade-mud branch September 24, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants