Adding sync support. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you launch vajax from a third plane with "async: false" option, don't work because "while(xhr.readyState != 4) { xhr.processEvents(); }" don't work for sync procedure. Now can skip this code if sync procedure is apply.
xhr.open() has fixed with async option, because "options.async || true" is true always. Now is true by default or false if you want sync procedure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola Christian, he estado trabajando con vajax. Me parece estupendo lo que has hecho, me has ahorrado un buen rato de trabajo. Al intentar usarlo en 3er. plano en modo síncrono he tenido problemas y los he resuelto.
Te dejo los detalles (los puse en inglés porque vi que tu también lo haces en tu código, por tanto para que sea coherente - no escribo inglés muy bien ;) - ):
If you launch vajax from a third plane with "async: false" option, don't work because "while(xhr.readyState != 4) { xhr.processEvents(); }" don't work for sync procedure. Now can skip this code if sync procedure is apply.
xhr.open() has fixed with async option, because "options.async || true" is true always. Now is true by default or false if you want sync procedure.