Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pfd now displays current mach #290

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

nakajimayoshi
Copy link
Member

@nakajimayoshi nakajimayoshi commented Mar 5, 2023

closes #281

wasm diff

See #12 for wasm module diff

Description

PFD Airspeed indicator now dispays mach above 0.4 when accelerating, with a 10s visual highlight.
After the value is displayed, the rendering threshold is moved to 0.38.

TODO:

  • determine when mach value is no longer rendered when decelerating.

Source material

-8 FCOM 10.10.2
https://www.youtube.com/watch?v=xU2axZ-Jh-A&start=1146
https://youtu.be/wrDQizpL2FM

Testing Instructions

Load aircraft in air. Set MCP speed to Mach 0.4 and use throttles/speedbrakes to accelerate and decelerate above & below 0.4.

Test Results

2023-03-08.00-21-32.mp4

Discord Username

@HowNowBrownCrow#2591

@nakajimayoshi nakajimayoshi added enhancement New feature or request PFD Issues with the Primary Flight Display labels Mar 5, 2023
@nakajimayoshi nakajimayoshi self-assigned this Mar 5, 2023
@nakajimayoshi nakajimayoshi changed the title new wasm module init feat: pfd now displays current mach Mar 5, 2023
@nakajimayoshi nakajimayoshi marked this pull request as ready for review March 7, 2023 15:32
@nakajimayoshi nakajimayoshi requested a review from kimlada March 7, 2023 15:37
@alokm95
Copy link

alokm95 commented Mar 19, 2023

Quality Assurance Tester

Discord : Alok #2913
Object of testing: #PR 290
Tier of Testing : 1
Date : 19/03/2023

Testing Process:
-Spawned on runway, set MCP to 0.4 Mach and took off
-Ensure that Mach number above 0.4 is rendered in PFD

Negatives: N/A

Testing Results:
Passed

Conclusions: Fixed as intended and LGTM

Media:
image

image

@nakajimayoshi nakajimayoshi added QA Tier 1 Needs QA Review Needs review from the QA team labels Mar 21, 2023
@nakajimayoshi nakajimayoshi merged commit 5df3eaa into Heavy-Division:experimental Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Needs QA Review Needs review from the QA team PFD Issues with the Primary Flight Display QA Tier 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants