-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new mode to conveyor grabbers #1720
base: master
Are you sure you want to change the base?
Conversation
What's the actual use-case for this? If I understand this right, then wouldn't that mean that if the items in the crate are used up faster than the grabber can provide them, the stacks would run out and the grabber would no longer grab anything? Also I'm not sure if I understand this code correctly:
It grabs the mode off the first filter without actually using the filter? That feels like a bit of a weird way to implement this, and I'm not sure people would even be aware of this functionality at all. Besides that, it means that only one filter mode is applicable for the entire container which is a bit of a weird restriction given that the entire point is to provide more item filters than the standard 3x3 grid. |
The primary use case is storage, where only inputs are handled automatically and outputs are done manually by a player.
I agree, this does feel quite weird. The idea was to allow to somehow switch between "item match" & "item & meta match" for the new grabber mode, but it ended up being unintuitive and, in my play-testing, not really useful. I'm all right with removing this functionality. |
There, the weird bit's gone now |
When using grabbers for storage automation, it is rather inconvenient to have to explicitly set up a whitelist for each, not to mention being limited to only storing 9 kinds of items per crate. I introduced a new mode to the grabber aimed at improving this: only grab items matching what's already stored in the connected inventory. Tested, works, as usual.
Also fixed the setting tool support for grabbers and extractors, now the whitelist-blacklist mode is copied along with the filter.