[std] make haxe.ds.HashMap unify with Iterable, closes #9055 #9066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you looked into cppia crash? |
|
Ah, no, I hadn't noticed. I guess that must be a cppia bug? |
|
Btw, the same fix may be needed for |
Most likely. |
|
@hughsando Could you check the cppia crash? Maybe @Gama11 can reduce it a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it work with static extensions such as those from
Lambda.It seems
@:tomethods would've been enough for unification to work, but not static extensions (related: HaxeFoundation/HaxeManual#444). So the only option seems to betocasts + adding the methods to the base class as well.