Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one-time listener is not removed from FlxSignal on HashLink #3004

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

T1mL3arn
Copy link
Contributor

@T1mL3arn T1mL3arn commented Jan 8, 2024

One-time listeners other than Void->Void is not removed from signals on HashLink (see HaxeFoundation/hashlink#578 ).

Use updated tests but old FlxSignal to see addOnce() does not work as expected on HashLink

haxelib run munit gen -filter flixel.util.FlxSignalTest
haxelib run lime test hl

#---
Class: flixel.util.FlxSignalTest .....!..........
    FAIL: massive.munit.AssertionException: Value [3] was not equal to expected value [1] at flixel.util.FlxSignalTest#testDispatchOnce_signal1 (175)
==============================
FAILED
Tests: 16  Passed: 15  Failed: 1 Errors: 0 Ignored: 0 Time: 0.005

@Geokureli Geokureli merged commit df424a4 into HaxeFlixel:dev Jan 8, 2024
16 checks passed
@Geokureli
Copy link
Member

Thanks!

@T1mL3arn T1mL3arn deleted the signal-fix branch January 8, 2024 14:21
@Geokureli Geokureli added this to the 5.6.0 milestone Jan 8, 2024
@Geokureli Geokureli added the Bug label Jan 8, 2024
Geokureli added a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants