Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of new locos #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

lookeypl
Copy link

Some locos I have collected throughout the time:

  • 456 from South London Network
  • 465 from Chatham Main Line
  • ALP-45DP from North Jersey Coast Line
  • Class 175 and Class 70 from South Wales Coastal

@Havner
Copy link
Owner

Havner commented Oct 14, 2016

Hey,

I've reviewed those a little and have a question. Those locos (I think) are pretty modern ones, but the ControlValues you used to detect them are very generic ones. Even though you did that with great detail (min/max values) it's safer to use some unique ControlValues that only such a loco has. It's not possible sometimes (especially for old ones), but for newer it should. Don't they have some like that?

@Havner Havner requested review from Havner and removed request for Havner February 12, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants