Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Check File Name Includes plugin to allow regex pattern #612

Merged

Conversation

Marnalas
Copy link
Contributor

@Marnalas Marnalas commented Mar 19, 2024

Hello there,

Resolves #606. This is my proposal for :

  1. Using regex patterns in the "Check file name includes" flow plugin
  2. Having the possibility to check in the file directory too

image

image
image
image

@Marnalas
Copy link
Contributor Author

@HaveAGitGat Hi, I see the checks are failing at "auto_compile_and_push" because of an error while executing a git command. I don't see more detail. Anything I can do on my side ?
(I'll ask this question on any of my PR that has this problem, feel free to answer only to one of them)

@HaveAGitGat
Copy link
Owner

Hmm well seems when trying to auto-compile any ts changes into js it fails with error 128 which is permissions related from stefanzweifel/git-auto-commit-action action. Will look into it.

@HaveAGitGat
Copy link
Owner

Ok so got there in the end. As mentioned here there is a workaround but can be a bit dangerous with fork PRs so I changed it so that it only auto builds PRs from the parent repo. For forks it just throws an error if someone has forgotten to commit their js changes.

Better way to do this would be to have PRs go to a dev branch and then I can have it auto build changes when I merge dev into master, might do that in future.

@HaveAGitGat
Copy link
Owner

Aside from that looks good and works well, ty.

@HaveAGitGat HaveAGitGat merged commit aaa02e8 into HaveAGitGat:master May 8, 2024
5 checks passed
@Marnalas
Copy link
Contributor Author

Marnalas commented May 8, 2024

Thank you for taking the time to describe the nature of the problem. Interesting food for thoughts !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT REQUEST] Extend Check File Name Includes plugin to allow regex pattern
2 participants