Flow plugin reorder streams - fix check to determine if reorder is necessary #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it not be simpler to just move |
|
You are perfectly right. Thank you for taking the time. One thing to note though is comparing the whole stream array to see if some items were switched is probably overkill. That's why I made an attempt with performance in mind. That being said, not sure the trade off is worth it. I'll let you be the judge of that ;) |
|
Yeah think it's fine doing it that way in this case as comparison is only being done once so the overhead isn't very much. Added here ty: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This is my proposal to fix #601.