Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix funding proposal tx lego #457

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix funding proposal tx lego #457

merged 2 commits into from
Dec 5, 2023

Conversation

santteegt
Copy link
Contributor

GitHub Issue

Reported issue

Changes

Fix funding proposal tx lego to set tx calldata to 0x instead of ENCODED_0X0_DATA

Packages Added

None

Checks

Before making your PR, please check the following:

  • Critical lint errors are resolved
  • App runs locally
  • App builds locally (run the build command for any impacted package and check for any errors before the PR)

@santteegt santteegt requested a review from skuhlmann December 5, 2023 04:20
@dekanbro dekanbro self-requested a review December 5, 2023 14:59
@dekanbro
Copy link
Contributor

dekanbro commented Dec 5, 2023

can we remove the ENCODED_0X0_DATA constant now? or is it used for something else?

@santteegt
Copy link
Contributor Author

yeah, added another commit to remove the unused constant

@skuhlmann skuhlmann merged commit f79045d into develop Dec 5, 2023
1 check passed
@skuhlmann skuhlmann deleted the fix/funding-proposal branch January 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuhlmann skuhlmann skuhlmann approved these changes

@dekanbro dekanbro Awaiting requested review from dekanbro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santteegt @dekanbro @skuhlmann