Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #80

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Develop #80

merged 2 commits into from
Dec 22, 2023

Conversation

erikhalt
Copy link
Contributor

Commit: ccfdaae
Bugfix. Couldnt start app, traced it back to an earlier commit. Changed back to the stage it worked

Commit: ec73cc4
FR #79 fixed

  • Ran the already existing Pytests for the changed as well as the workflow test

Traceback (most recent call last):
  File
  "\Python\Python310\lib\site-packages\pyttman\tools\pyttmancli\intents.py",
  line 120, in respond
      app = bootstrap_app(devmode=True, module=app_name)
        File
	"\Python\Python310\lib\site-packages\pyttman\tools\pyttmancli\terraforming.py",
	line 157, in bootstrap_app
	    depr_raise("Please rename 'MESSAGE_ROUTER' to 'MIDDLEWARE'
	    in "
	      File
	      "\Python\Python310\lib\site-packages\pyttman\core\internals.py",
	      line 26, in depr_raise
	          raise DeprecationWarning(out)
		  DeprecationWarning: Please rename 'MESSAGE_ROUTER' to
		  'MIDDLEWARE' in 'settings.py' for this application. -
		  This was deprecated in version 1.1.11.
from-see below
Pyttman\pyttman\tools\pyttmancli\terraforming.py
144: logger = logging.getLogger(f"Pyttman logger")
to-see below
Pyttman\pyttman\tools\pyttmancli\terraforming.py
144: logger = logging.getLogger(f"Pyttman logger on app {app_name}")
@dotchetter
Copy link
Collaborator

Very nice, thanks for the contribution! 👍

@dotchetter dotchetter merged commit f6c4a78 into Hashmap-Software-Agency:develop Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants