Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gitattributes and remove binary plot data from jupyter notebooks #81

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Add .gitattributes and remove binary plot data from jupyter notebooks #81

merged 2 commits into from
Sep 15, 2024

Conversation

austinschneider
Copy link
Collaborator

@austinschneider austinschneider commented Sep 15, 2024 •
edited
Loading

This PR makes three changes:

  • Sets the linguist-vendored property on the vendor/ folder in .gitattributes so that we ignore contributions from external code
  • Sets the linguist-detectable property to false on *.ipynb files so they are ignored
  • Removes cell outputs (mostly large plots) from the jupyter notebooks

@austinschneider austinschneider added the enhancement New feature or request label Sep 15, 2024
@austinschneider austinschneider self-assigned this Sep 15, 2024
dnewmark99
dnewmark99 approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@dnewmark99 dnewmark99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@austinschneider austinschneider merged commit 7d2db08 into main Sep 15, 2024
31 checks passed
marichavest pushed a commit that referenced this pull request Oct 2, 2024
@austinschneider @marichavest
Add .gitattributes and remove binary plot data from jupyter notebooks (…
6443dca 
…#81)

* Ignore vendor folder. Ignore jupyter notebooks

* Clear cells in jupyter notebooks
@austinschneider austinschneider deleted the dev/languages branch October 18, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnewmark99 dnewmark99 dnewmark99 approved these changes

@nickkamp1 nickkamp1 Awaiting requested review from nickkamp1

Assignees

@austinschneider austinschneider

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinschneider @dnewmark99