SIREN ND280+ MODULE ADDITION #73
Conversation
CORRECTED FLUXCALCULATOR EVENT GENERATION DENSITY PLOT
IN MATHEMATICA
|
VISUAL INTERFACE CREATED FOR MATHEMATICA IN /resources/Detectors/visuals/ |
There was a problem hiding this comment.
@mingshauliu most of the changes look good! there are a few extraneous files that should be removed before merging (e.g., all the ".DS_Store" files and the "test_jul20.ipynb" file). Also could you revert the changes to the PaperPlots notebooks? I would like those to remain consistent with the paper. You can keep the DipolePortal_ND280UPGR.py file though, that will be useful for users
There was a problem hiding this comment.
After changes in above comment I will approve this PR. @austinschneider feel free to add any comments you might have though
|
I agree with @nickkamp1 's comments. As far as the extraneous files go, I think they either need to be removed from the history or we can do a squash merge to keep them out of the history. |
|
Thank you both for the comments! I've deleted the extraneous files and reverted both PaperPlots, I'll request a review again. Let me know if anything else is needed! |
Makes sense to me. Let's do a squash merge |
* Dimension file of ND280 Upgrade * Dimensions added * ND280 Upgrade detector material file * ND280 Upgrade component materials added * Added rock * space * delete redundant comments * ND28P UPGRD EVENT GENERATION * CHANGED EXPERIMENT FILE * Deep inelastic scattering within ND280 upgrade * ISOTROPIC NEUTRINO INJECTION AND PLOT * DIS plot for ND280+ * z shift of detector coordinates * ND280+ PLOT UPDATE * INJECTION GEOMETRY UPDATES * EFFECTIVE AREA CALCULATION FOR ND280+ * NEUTRINO FLUX FOR T2K NEAR DETECTOR 2020 * ADDED FLUX CALCULATOR AND PROCESSED NU ENHANCED DATA * NU ENHANCED DATA PROCESSED * NEW FLUX CALCULATOR THAT RETURNS FILE W/O WRITING * MOVE TO CORRECT DIRECTORY * MOVE DIRECTORY * JPARC NEUTRINO FLUX CALCULATOR EST. 2020 * RESTRUCTURED FLUX DATA * CORRECTED FIDUCIAL VOL CORRECTED FLUXCALCULATOR EVENT GENERATION DENSITY PLOT * FLUX CALCULATION FOR ND280+ * CREATED VISUAL INTERFACE FOR DETECTORS IN MATHEMATICA * CREATED VISUAL INTERFACE IN MATHEMATICA * added read me * added readme * Update README.md * Delete .DS_Store * Delete resources/.DS_Store * Delete resources/Detectors/.DS_Store * Delete resources/Detectors/densities/.DS_Store * Delete resources/Detectors/materials/.DS_Store * Delete resources/Examples/.DS_Store * Delete resources/Fluxes/.DS_Store * Delete resources/Fluxes/T2K_NEAR/.DS_Store * Delete notebooks/test_jul20.ipynb * Delete resources/Examples/Example1/.DS_Store * Revert PaperPlots for Example2 * Revert PaperPlots in Example1 * Delete resources/Fluxes/T2K_NEAR/T2K_NEAR-v1.0/.DS_Store
The density and material files are done and checked, I presented the Mathematica 'CAD' in GM but I can automate that too.
The injection uses high energy supernova in the deep-inelastic scattering example.