Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LeptonInjector --> SIREN #64

Merged
merged 13 commits into from
Mar 19, 2024
Merged

Rename LeptonInjector --> SIREN #64

merged 13 commits into from
Mar 19, 2024

Conversation

austinschneider
Copy link
Collaborator

No description provided.

@austinschneider austinschneider marked this pull request as ready for review March 9, 2024 00:49
@austinschneider austinschneider self-assigned this Mar 9, 2024
@austinschneider
Copy link
Collaborator Author

austinschneider commented Mar 9, 2024 •
edited
Loading

This is largely ready to go. The main things that might need changing are:

  • The installation instructions which currently reference the non-existent siren package
  • The jupyter notebooks, which I did not modify
  • The namespace we use in the C++ code. I replaced LI:: with SI::, but maybe is makes more sense to use either siren:: or SIREN::

@austinschneider
Copy link
Collaborator Author

We have the name siren on pypi now, so I think this is ready to merge!

@austinschneider austinschneider mentioned this pull request Mar 18, 2024
Closed
@austinschneider austinschneider linked an issue Mar 18, 2024 that may be closed by this pull request
Missing package dependencies #56
Closed
nickkamp1
nickkamp1 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@nickkamp1 nickkamp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out locally, made a very small bug fix but otherwise looks good to me! Onward to SIREN

@austinschneider austinschneider merged commit ec73d96 into main Mar 19, 2024
5 of 6 checks passed
@austinschneider austinschneider deleted the siren branch October 18, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickkamp1 nickkamp1 nickkamp1 approved these changes

Assignees

@austinschneider austinschneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing package dependencies
2 participants
@austinschneider @nickkamp1