Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Processes to classes and add an inheritance relationship betwe… #40

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Change Processes to classes and add an inheritance relationship betwe… #40

merged 4 commits into from
Jan 10, 2024

Conversation

austinschneider
Copy link
Collaborator

…en PhysicalProcess and InjectionProcess

@austinschneider austinschneider self-assigned this Jan 10, 2024
@austinschneider austinschneider added the enhancement New feature or request label Jan 10, 2024
@austinschneider
Copy link
Collaborator Author

I think this is good to go now

nickkamp1
nickkamp1 reviewed Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@nickkamp1 nickkamp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable. I think this might require some updates to LIController. I will test locally and re-review

@austinschneider
Copy link
Collaborator Author

austinschneider commented Jan 10, 2024 •
edited
Loading

Code changes look reasonable. I think this might require some updates to LIController. I will test locally and re-review

I think the main issue is going to be the SetCrossSections method that I removed from the pybindings. I can either add it back in or LIController can just use the property access to cross_sections. Otherwise I don't see any problems in LiController.

@nickkamp1
Copy link
Collaborator

Code changes look reasonable. I think this might require some updates to LIController. I will test locally and re-review

I think the main issue is going to be the SetCrossSections method that I removed from the pybindings. I can either add it back in or LIController can just use the property access to cross_sections. Otherwise I don't see any problems in LiController.

Updating LIController to just access cross_sections, I think that's cleaner

nickkamp1
nickkamp1 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@nickkamp1 nickkamp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to go now!

@austinschneider austinschneider merged commit ff5c8c8 into main Jan 10, 2024
0 of 14 checks passed
@austinschneider austinschneider deleted the dev/process_inheritance branch January 22, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickkamp1 nickkamp1 nickkamp1 approved these changes

Assignees

@austinschneider austinschneider

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinschneider @nickkamp1