Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/warnings #39

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Dev/warnings #39

merged 5 commits into from
Jan 10, 2024

Conversation

austinschneider
Copy link
Collaborator

Fix some compilation warnings

nickkamp1
nickkamp1 reviewed Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@nickkamp1 nickkamp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the one question about is_outside

@austinschneider
Update Geometry_TEST.cxx
a38925e 
Remove is_outside
nickkamp1
nickkamp1 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@nickkamp1 nickkamp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge!

@nickkamp1 nickkamp1 merged commit 0708ae2 into main Jan 10, 2024
0 of 14 checks passed
@nickkamp1 nickkamp1 deleted the dev/warnings branch January 10, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickkamp1 nickkamp1 nickkamp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinschneider @nickkamp1