Enforce gofmt in TravisCI (#164)

Add a script run at build time that checks Go formatting and fails if it
needs formatting.

.travis.yml

@@ -27,6 +27,7 @@ before-install:
   - nvm use stable
   - cd service/ && go get -u -v -d && cd ..
   - cd tests/ && npm install && npm install chromedriver geckodriver && cd ..
+  - gofmt -l .
 
 
 script:
@@ -36,8 +37,7 @@ script:
   - npm install -g http-server mocha eslint
   - eslint view/web/app-jarvis.js
   - echo "checking go format ..."
-  - diff -u <(echo -n) <(gofmt -d ./src ./tsdb)
-  - echo "perfect go format. moving ahead ..."
+  - build/scripts/gofmt.sh
   - cd view/web/ && npm start && cd ../..
   - go test service/controllers/controllers_test.go
   - cd tests/

build/scripts/gofmt.sh

@@ -0,0 +1,9 @@
+#!/bin/bash
+
+echo 'running go fmt on all packages...'
+invalidFiles=$(gofmt -l . 2>&1)
+if [ "$invalidFiles" ]; then
+  echo "These files did not pass the 'go fmt' check, please run 'go fmt' on them:"
+  echo $invalidFiles
+  exit 1
+fi

service/controllers/controllers.go

@@ -36,7 +36,7 @@ func MessagesController(w http.ResponseWriter, r *http.Request) {
 
 func filterForSpeech(s string) string {
 
-	s = strings.Replace(s, "?", " ", -1)
+	s =   strings.Replace(s, "?", " ", -1)
 	s = strings.Replace(s, "%", " ", -1)
 	s = strings.Replace(s, "#", " ", -1)
 	s = strings.Replace(s, "$", " ", -1)
@@ -404,4 +404,4 @@ func scrapeYahoo(query string) []messageQueryBody {
 		resultObj = append(resultObj, resultElement)
 	}
 	return resultObj
-}
+}