Skip to content

Commit

Permalink
use correct scope
Browse files Browse the repository at this point in the history
  • Loading branch information
Hanashi committed Oct 17, 2024
1 parent 358995f commit 5b74ab6
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion files/lib/data/faq/Question.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ final class Question extends DatabaseObject implements IRouteController, ISearch
*/
protected static $databaseTableIndexName = 'questionID';

protected GroupedAttachmentList $attachmentList;
private GroupedAttachmentList $attachmentList;

#[Override]
public function getTitle(): string
Expand Down
2 changes: 1 addition & 1 deletion files/lib/data/faq/QuestionAction.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public function update()
}
}

protected function updateSearchIndex($object)
private function updateSearchIndex($object)
{
if (isset($this->parameters['answer_i18n'])) {
foreach ($this->parameters['answer_i18n'] as $languageID => $answer) {
Expand Down
2 changes: 1 addition & 1 deletion files/lib/data/faq/QuestionList.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ final class QuestionList extends DatabaseObjectList
*/
public $sqlOrderBy = 'showOrder, questionID';

protected GroupedAttachmentList $attachmentList;
private GroupedAttachmentList $attachmentList;

public function readAttachments()
{
Expand Down
2 changes: 1 addition & 1 deletion files/lib/data/faq/category/FaqCategory.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ final class FaqCategory extends AbstractDecoratedCategory implements IAccessible
{
public const OBJECT_TYPE_NAME = 'dev.tkirch.wsc.faq.category';

protected array $userPermissions = [];
private array $userPermissions = [];

private bool $prefix = false;

Expand Down
6 changes: 3 additions & 3 deletions files/lib/data/faq/category/FaqCategoryCache.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ final class FaqCategoryCache extends SingletonFactory
* number of total questions
* @var int[]
*/
protected array $questions;
private array $questions;

protected function initQuestions()
private function initQuestions()
{
$this->questions = [];

Expand All @@ -38,7 +38,7 @@ protected function initQuestions()
$this->countQuestions($categoryToParent, $contacts, 0);
}

protected function countQuestions(array $categoryToParent, array &$contacts, $categoryID)
private function countQuestions(array $categoryToParent, array &$contacts, $categoryID)
{
$count = (isset($contacts[$categoryID])) ? $contacts[$categoryID] : 0;
if (isset($categoryToParent[$categoryID])) {
Expand Down
2 changes: 1 addition & 1 deletion files/lib/data/faq/category/FaqCategoryNode.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ final class FaqCategoryNode extends CategoryNode
*/
protected static $baseClass = FaqCategory::class;

protected int $questions;
private int $questions;

#[Override]
public function getItems(): int
Expand Down
4 changes: 2 additions & 2 deletions files/lib/page/FaqQuestionListPage.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ class FaqQuestionListPage extends AbstractPage
*/
public $neededPermissions = ['user.faq.canViewFAQ'];

public int $showFaqAddDialog = 0;
protected int $showFaqAddDialog = 0;

public ?FaqCategory $category;
protected ?FaqCategory $category;

#[Override]
public function readParameters()
Expand Down
2 changes: 1 addition & 1 deletion files/lib/page/FaqQuestionPage.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class FaqQuestionPage extends AbstractPage

protected Question $question;

public ?FaqCategory $category;
protected ?FaqCategory $category;

#[Override]
public function readParameters()
Expand Down
2 changes: 1 addition & 1 deletion files/lib/system/search/FaqQuestionSearch.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

final class FaqQuestionSearch extends AbstractSearchProvider
{
protected array $faqCache = [];
private array $faqCache = [];

#[Override]
public function cacheObjects(array $objectIDs, ?array $additionalData = null): void
Expand Down

0 comments on commit 5b74ab6

Please sign in to comment.