further fixes

HaloSpaceStation · Jun 3, 2024 · cb56a30 · cb56a30
1 parent 58815e3
commit cb56a30
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 16 deletions.
diff --git a/code/_helpers/unsorted.dm b/code/_helpers/unsorted.dm
@@ -1134,9 +1134,9 @@ GLOBAL_DATUM_INIT(dview_mob, /mob/dview, new)
 		set_light(origin.light_range, origin.light_power, origin.light_color)
 
 /mob/dview/Initialize()
-	..()
+	. = ..()
 	// We don't want to be in any mob lists; we're a dummy not a mob.
-	SSmobs.mob_list -= src
+	STOP_PROCESSING(SSmobs, src)
 
 // call to generate a stack trace and print to runtime logs
 /proc/crash_with(msg)

diff --git a/code/controllers/Processes/chemistry.dm b/code/controllers/Processes/chemistry.dm
@@ -7,7 +7,7 @@ var/datum/controller/process/chemistry/chemistryProcess
 
 /datum/controller/process/chemistry/setup()
 	name = "chemistry"
-	schedule_interval = 20 // every 2 seconds
+	schedule_interval = 2 SECONDS
 	chemistryProcess = src
 	active_holders = list()
 	chemical_reactions = chemical_reactions_list

diff --git a/code/modules/halo/vehicles/vehiclebase.dm b/code/modules/halo/vehicles/vehiclebase.dm
@@ -328,7 +328,7 @@
 			var/list/drivers = get_occupants_in_position("driver")
 			if(!drivers.len || isnull(drivers) || movement_destroyed)
 				inactive_pilot_effects()
-	if(spawn_datum)
+	if(!isnull(spawn_datum) && !ispath(spawn_datum))
 		spawn_datum.process_resource_regen()
 
 /obj/vehicles/proc/update_object_sprites() //This is modified on a vehicle-by-vehicle basis to render mobsprites etc, a basic render of playerheads in the top right is used if no overidden.

diff --git a/code/modules/mob/mob.dm b/code/modules/mob/mob.dm
@@ -45,10 +45,6 @@
 /mob/Initialize()
 	. = ..()
 	START_PROCESSING(SSmobs, src)
-	..()
-
-/mob/Initialize()
-	. = ..()
 	last_z = z
 	var/obj/om_obj = map_sectors["[z]"]
 	if(om_obj)

diff --git a/code/modules/mob/observer/virtual/base.dm b/code/modules/mob/observer/virtual/base.dm
@@ -67,9 +67,4 @@ var/list/all_virtual_listeners = list()
 	return ..()
 
 /atom/movable/proc/shall_have_virtual_mob()
-	return TRUE
-
-/mob/shall_have_virtual_mob()
-	var/init_virt = initial(virtual_mob)
-	if(!isnull(init_virt))
-		return ispath(init_virt)
+	return ispath(initial(virtual_mob))
diff --git a/maps/_gamemodes/firefight/overmind.dm b/maps/_gamemodes/firefight/overmind.dm
@@ -11,7 +11,7 @@
 
 /datum/npc_overmind/firefight/New()
 	. = ..()
-START_PROCESSING(SSobj, src)
+	START_PROCESSING(SSobj, src)
 
 /datum/npc_overmind/firefight/create_taskpoint_assign()
 	//intentionally left blank

diff --git a/test/check-paths.sh b/test/check-paths.sh
@@ -2,7 +2,7 @@
 set -e
 
 WORLD_LOG_COUNT=40
-ANGLE_BRACKET_COUNT=730
+ANGLE_BRACKET_COUNT=731
 
 FAILED=0