Skip to content

Commit

Permalink
Refactor set_viscous_BBL channel drag calculations
Browse files Browse the repository at this point in the history
  Refactored set_viscous_BBL to separate out the routines setting the open
interface lengths used for the channel drag, shortening a 1070 line long routine
to 915 lines and reducing the scope of a number of temporary variables.  A
number of logical branch points have been moved outside of the innermost do
loops.  This refactoring will also make it easier to provide alternatives to
some of the solvers that do not use the trigonometric functions to solve for the
roots of a cubic expression and avoiding the issues noted at
NOAA-GFDL/issues/483.  All answers are bitwise identical and public
interfaces are unchanged.
  • Loading branch information
Hallberg-NOAA committed Jan 9, 2024
1 parent a03bb95 commit f6547da
Showing 1 changed file with 322 additions and 189 deletions.
Loading

0 comments on commit f6547da

Please sign in to comment.