Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for split transactions #96

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

dospuntos
Copy link
Contributor

@dospuntos dospuntos commented Jul 8, 2024

  • Replace "Split transaction" with "Split"
  • Restore orginal category when un-splitting
  • Update catkeys
  • Don't validate 'Split' category for split transactions
  • Remove 'Split' as shortcut when entering new transaction

@dospuntos
Copy link
Contributor Author

@humdingerb - I added the new translations for "Split"

* Replace "Split transaction" with "Split"
* Restore orginal category when un-splitting
* Update catkeys
* Don't validate 'Split' category for split transactions
@dospuntos dospuntos force-pushed the split-transactions branch from 1fe11c3 to 92be913 Compare July 11, 2024 13:08
@dospuntos
Copy link
Contributor Author

@humdingerb - This should be ready to merge now, if it looks OK with you.

@humdingerb
Copy link
Member

Looks good, but there are still a couple of B_TRANSLATE_CONTEXT("Split", "CommonTerms") that should also be converted to a B_TRANSLATE_ALL (I assume all the 'noun' variant).

@dospuntos dospuntos force-pushed the split-transactions branch from 92be913 to ca52bba Compare July 12, 2024 00:31
@dospuntos
Copy link
Contributor Author

Looks good, but there are still a couple of B_TRANSLATE_CONTEXT("Split", "CommonTerms") that should also be converted to a B_TRANSLATE_ALL (I assume all the 'noun' variant).

Thanks for checking, I've updated them.

@humdingerb
Copy link
Member

Thanks!

@humdingerb humdingerb merged commit 66dbec9 into HaikuArchives:master Jul 12, 2024
2 of 3 checks passed
@dospuntos dospuntos deleted the split-transactions branch July 12, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants