Use system date format #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korli
reviewed
May 27, 2024
|
Looks good, except for the conflicts |
dospuntos
force-pushed
the
use-system-date-format
branch
from
4928e3c to
153d64a
Compare
dospuntos
force-pushed
the
use-system-date-format
branch
from
153d64a to
cfbab45
Compare
Thanks @korli - I've fixed the conflicts. |
|
Very good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes CapitalBe's date logic, and displays all dates using the system settings. This also removes the need for date settings in the settings dialog.
Fixes #6
Note that the
-key was a keyboard shortcut to change the date field to the previous day, but I had to remove it because it is also a valid date separator in some locales.Date settings are still left in the database, but these can be handled if database versioning is implemented. (PR #62 ).