More layout tweaks #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a checkbox instead of a button for "Show/Hide split". * Add a horizontal separator as a visual to the "Split" part. * Keep all text fields a fixed size, only grow the Payee and Memo fields when the window is resized. * Add labels above the text fields in the "Split" view, too. * Remove the "frame" variable when creating the TransactionEditWindow. As we use layout management, there's no need to supply a window size. This has the nice consequence that wen opened with the "Split" hidden, the window isn't taller than needed. Unfortunately, the window doesn't auto-shrink when hiding the "Split" again... Also: For some reason the window is only horizontally resizable when the "Split" is shown. Why? * Removed unneeded member variables for labels and the help button. * Removed no longer needed Zeta work-around.
* Adds the currency symbol to the total sum of all splits. * Colour the "Total" B_FAILURE_COLOR if the total sum of all splits don't add up to the transaction amount. * Updated en.catkeys
* Use a similar layout to the split transaction window, i.e. labels over text fields. Those text fields are disabled, because they aren't editable. * Use B_TRANSLATION_CONTEXT "SplitView" for the labels to avoid translation work. * Move "Repeat" settings from te right to the bottom. * Make window horizontally resizable.
* Move "Reports" to the right, above the column list and to the left of start/end dates. This reduces the large unused area above the column list. * Move the help button up to the right top corner of the window. * Limit the date text field's width. * Removed unneded translations of internal widget names.
* Use a checkbox instead of a button for "Show/Hide split". * Add a horizontal separator as a visual to the "Split" part. * Keep all text fields a fixed size, only grow the Payee and Memo fields when the window is resized. * Add labels above the text fields in the "Split" view, too. * Remove the "frame" variable when creating the TransactionEditWindow. As we use layout management, there's no need to supply a window size. This has the nice consequence that wen opened with the "Split" hidden, the window isn't taller than needed. Unfortunately, the window doesn't auto-shrink when hiding the "Split" again... Also: For some reason the window is only horizontally resizable when the "Split" is shown. Why? * Removed unneeded member variables for labels and the help button. * Removed no longer needed Zeta work-around. * Use "clang-format off/on" around layout code blocks to avoid clang 'fixing' the style. Thanks for the heads-up, @korli!
* Add help button at the top right corner 'over' the menu bar . There isn't really space anywhere else. * Add the name of the currently budgeted category in the budget category box's label. * Rename "Edit category:" to "Budget category:". * Increase the width of the "Budget Editor" so the columns aren't cut off. * Remove horizontal scrollbar from the "Budget Editor". The vertical scrollbar appears to be a fixed property of BColumnListViews. * Remove unneeded background BView. * Change the initial window size to avoid needlessly tall "Summary" list at the bottom and fit all columns without having to scroll. * Make "Summary" columns slightly wider to allow larger amounts.
* Move "Enter" button to the right in the CheckView. This saves a bit of vertical space, as it's useful to see as many transactions in the list as possible. * Make the window a B_DOCUMENT_WINDOW to get the advantages of a full sized resize corner. * Move the "Help" button to the right of the menu bar on top. It's a good place when there's a menu bar as it doesn't waste any space and it's more obvious that it's the help to the whole window, not just the view it's located in. * Restrict column width in the CheckView similar to the Split/Transaction window. * Removed some old layouting code no longer needed after moving to Haiku's layout management.
* Move "Categories" to the application (icon) menu. It has nothing to do with "Files". * Move "Report a bug" down to "About". Fits better. * "Scheduled transactions" doesn't fit into "Files", either. Move to "Tools", not perfect but better than all other existing menus...
* Simplified to use group layout. * Adjust the Payee column to its widest entry. * Fix typo.
* Category window:
+ Simplify layout using Group layouts.
+ Center buttons
+ Only enable "Edit" and "Remove" buttons if not a superitem
(Income/Spending) is selected. Those can't be renamed or
deleted.
* Edit category window
+ Layout tweaks
* Add category window:
+ Use radio buttons for Income/Spending instead of one checkbox.
+ After adding a category, close the window.
When you're entering many new categories it may be nice to keep
the window open. But if you don't happen to that new category
added to the list in the main category window, you're never sure
it got added alright.
+ Disable OK button when window opens and the name field is empty.
+ Layout tweaks
* Remove category window:
+ Only enable "OK" button if not a superitem (Income/Spending) is
selected. Those can't be chosen as subsitute for the transaction
of the to be removed category.
+ Layout tweaks
|
Here are screenshots of all changes: Account settings Old: New: Budget Old: New: Category add Old: New: Category edit Old: New: Category remove New: Categories Old: New: Main Window Old: New: Report Old: New: Schedule transaction Old: New: Settings Old: New: |
|
I think this PR is ready now. |
korli
reviewed
May 26, 2024
korli
reviewed
May 26, 2024
korli
reviewed
May 26, 2024
korli
reviewed
May 26, 2024
|
A few comments, otherwise LGTM |
* Account settings
+ Show the "Currency format" as BBox label. Saves the extra
StringView.
+ Layout tweaks
+ Fix crash when renaming an account.
+ For new accounts, change the window title to "New accounts"
instead of using the same "Account settings".
* CapitalBe settings
+ Rename from "Options" to "Settings", just like the menu item.
+ Center "Default account settings" and increase font size a bit.
+ Show "Currency/Date format" as BBox labels. Saves the extra
StringViews.
+ Use another date than 01.01.1970, because that doesn't show
the difference between MDY and DMY setting...
* Use B_USE_BIG_SPACING instead of "font.Size() * 1.3" everywhere
that was used to space BBox labels.
|
@humdingerb this looks very nice, great work!
Reconciling is used to compare the registered transactions with the actual bank statement, and make sure all transactions are correctly added to CapitalBe, including interests and bank charges. You enter the starting amount and ending amount from your bank statement, and all transactions for that period should match (the 'Unreconciled total' field shows the difference. I haven't checked the logic in detail, but it seems to work. However, I think there should either be a starting and ending date, or just a way to select a month. In addition, ideally reconciled transactions should be locked/not editable, or at least highlighted in some way in the transaction list (reconciled transactions are marked as such in the database). |
|
Thanks for the info, @dospuntos . I guess I should take the time to enter my actual transactions of a month or two to try with real-world data. No more "edgfed" and "iurrerojjl" as category and payee... :) Merging this thing anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few more to follow. Don't merge yet...