Layout tweaks #59
Merged
Layout tweaks #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make window resizable * Remove unneeded background BView * Align textcontrols in grid
|
These deal with the transfer and split/transaction windows. It among other things uses a bit more spacing.
After:
After: |
korli
reviewed
May 23, 2024
korli
reviewed
May 23, 2024
* Use a checkbox instead of a button for "Show/Hide split". * Add a horizontal separator as a visual to the "Split" part. * Keep all text fields a fixed size, only grow the Payee and Memo fields when the window is resized. * Add labels above the text fields in the "Split" view, too. * Remove the "frame" variable when creating the TransactionEditWindow. As we use layout management, there's no need to supply a window size. This has the nice consequence that wen opened with the "Split" hidden, the window isn't taller than needed. Unfortunately, the window doesn't auto-shrink when hiding the "Split" again... Also: For some reason the window is only horizontally resizable when the "Split" is shown. Why? * Removed unneeded member variables for labels and the help button. * Removed no longer needed Zeta work-around. * Use "clang-format off/on" around layout code blocks to avoid clang 'fixing' the style. Thanks for the heads-up, @korli!
|
LGTM |
|
Let's merge then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.