-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #7: Memo bug #45
Conversation
As there is no working email address to send a report to, it may be best to remove that part. What could be nice is to offer to create the bug report file and propose to upload it to CapitalBe's issue tracker. A button that'll open https://github.com/HaikuArchives/CapitalBe/issues would be nice, too, but only if clicking it wouldn't dismiss the alert... |
Build failed on x86_gcc2:
|
I've reverted to the previous version of CppSQLite3, the latest version seems to be using features not supported by GCC2. Debugging and refactoring this is goes a bit over my head... |
We could switch to gcc 13 on x86. Maybe after this change? |
Looks good to me. |
@humdingerb - can this be merged now? There's a conflict with |
Unfortunatley, the PR cannot be merged until the conflicts are solved. |
The latest version of CppSQLite3 was included from https://github.com/neosmart/CppSQLite. This fixes some warning messages during build.
3dad9f2
to
28db852
Compare
OK, should be solved now, thank you for your patience and your instructions. More PR's coming soon (hopefully) with system colors etc. |
Remove option to send email with bug report. Update catkeys. Revert previous upgrade of CppSQLite3. Co-authored-by: humdinger <[email protected]>
@dospuntos, ready to put CapitalBe up at Polyglot or do you anticipate more immediate string related changes? |
@humdingerb Please wait for for the next PR, there are some minor changes there. |
Will do. |
This PR fixes a problem with escaped characters in transaction memos. Fixes #7
I've also included an updated version of the CppSQLite3 library from https://github.com/neosmart/CppSQLite. The previous version caused some non-fatal warnings during the build process. I haven't seen any issues with this change.
In addition, some missing strings where added for translation, as mentioned in
ToDo_Spanish
. Maybe this program can be added to Polyglot at some point for additional translations?Note that the bug report message (
CapitalBe has run into a bug
) is translatable, but not the actual bug report that will be saved and possibly sent to a developer.