Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7: Memo bug #45

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Issue #7: Memo bug #45

merged 3 commits into from
Apr 30, 2024

Conversation

dospuntos
Copy link
Contributor

This PR fixes a problem with escaped characters in transaction memos. Fixes #7
I've also included an updated version of the CppSQLite3 library from https://github.com/neosmart/CppSQLite. The previous version caused some non-fatal warnings during the build process. I haven't seen any issues with this change.

In addition, some missing strings where added for translation, as mentioned in ToDo_Spanish. Maybe this program can be added to Polyglot at some point for additional translations?

Note that the bug report message (CapitalBe has run into a bug) is translatable, but not the actual bug report that will be saved and possibly sent to a developer.

@humdingerb
Copy link
Member

As there is no working email address to send a report to, it may be best to remove that part.

What could be nice is to offer to create the bug report file and propose to upload it to CapitalBe's issue tracker. A button that'll open https://github.com/HaikuArchives/CapitalBe/issues would be nice, too, but only if clicking it wouldn't dismiss the alert...

@korli
Copy link
Contributor

korli commented Apr 23, 2024

Build failed on x86_gcc2:

g++ -c src/Account.cpp  -Iobjects.x86-cc2-release/  -Isrc/ -I-  -I/boot/system/develop/headers/private/interface  -O3    -o "objects.x86-cc2-release/Account.o"
In file included from /home/runner/work/CapitalBe/CapitalBe/src/Database.h:9,
                 from /home/runner/work/CapitalBe/CapitalBe/src/Account.cpp:4:
/home/runner/work/CapitalBe/CapitalBe/src/CppSQLite3.h:42: parse error before `&&'
/home/runner/work/CapitalBe/CapitalBe/src/CppSQLite3.h:44: parse error before `&&'
/home/runner/work/CapitalBe/CapitalBe/src/CppSQLite3.h:44: `detail::SQLite3Memory::operator =(...)' must take exactly one argument
/home/runner/work/CapitalBe/CapitalBe/src/CppSQLite3.h:59: confused by earlier errors, bailing out
/boot/system/develop/etc/makefile-engine:300: recipe for target 'objects.x86-cc2-release/Account.o' failed

src/Locale.cpp Outdated Show resolved Hide resolved
@dospuntos
Copy link
Contributor Author

I removed the option to report bugs by email, not sure if the wording is fine? This is what the bug alert looks like:

CapitalBe bugreport

Clicking "Save bugreport" will save a file to the desktop and open the browser to GitHub.

Still looking into the build fail on x86_gcc2

@dospuntos
Copy link
Contributor Author

Build failed on x86_gcc2:

I've reverted to the previous version of CppSQLite3, the latest version seems to be using features not supported by GCC2. Debugging and refactoring this is goes a bit over my head...

@korli
Copy link
Contributor

korli commented Apr 24, 2024

Build failed on x86_gcc2:

I've reverted to the previous version of CppSQLite3, the latest version seems to be using features not supported by GCC2. Debugging and refactoring this is goes a bit over my head...

We could switch to gcc 13 on x86. Maybe after this change?

@korli
Copy link
Contributor

korli commented Apr 24, 2024

Looks good to me.

@dospuntos
Copy link
Contributor Author

@humdingerb - can this be merged now? There's a conflict with en.catkeys, after a previous merge, but I'm not sure how to solve that here on the PR, maybe the simplest way is to regenerate it after merging?

@humdingerb
Copy link
Member

Unfortunatley, the PR cannot be merged until the conflicts are solved.
You need to switch to your PR branch, do a "git rebase master" and solve the conflicts that are pointed out. After you removed the conflicting parts, do a "git add locales/en.catkeys" and git rebase --continue".

The latest version of CppSQLite3 was included
from https://github.com/neosmart/CppSQLite. This
fixes some warning messages during build.
@dospuntos dospuntos force-pushed the 7-memo-bug branch 2 times, most recently from 3dad9f2 to 28db852 Compare April 29, 2024 18:41
@dospuntos
Copy link
Contributor Author

OK, should be solved now, thank you for your patience and your instructions. More PR's coming soon (hopefully) with system colors etc.

src/Locale.cpp Outdated Show resolved Hide resolved
Remove option to send email with bug report.
Update catkeys.
Revert previous upgrade of CppSQLite3.
Co-authored-by: humdinger <[email protected]>
@humdingerb humdingerb merged commit cb24ba2 into HaikuArchives:master Apr 30, 2024
2 of 3 checks passed
@humdingerb
Copy link
Member

@dospuntos, ready to put CapitalBe up at Polyglot or do you anticipate more immediate string related changes?

@dospuntos
Copy link
Contributor Author

@humdingerb Please wait for for the next PR, there are some minor changes there.

@humdingerb
Copy link
Member

Will do.

@dospuntos dospuntos deleted the 7-memo-bug branch May 7, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Memo in Transactions is weird .
3 participants