Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menus #105

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Context menus #105

merged 3 commits into from
Jul 30, 2024

Conversation

humdingerb
Copy link
Member

@humdingerb humdingerb commented Jul 25, 2024 •
edited
Loading

  • Context menus for Accounts and Transactions lists
  • Fix CalendarWindow placement

@humdingerb
Fix placement of calendar window
c9cf0f4 
Before, the placement wasn't correct for smaller or bigger font sizes.

For some reason, window->Bounds() always returns the coordinates of the
CalenderMenuWindow's ctor, BRect(0.0, 0.0, 100.0, 130.0), not the actual
size.
Using GetLayout()->PreferredSize() instead works...
@humdingerb
Add context menus to Transaction and Accounts list
062e273 
* Create classes AccountList and TransactionList to be able to implement
  MouseDown() to show popup menus.

* Re-use B_TRANSLATION_CONTEXT "MainWindow" to avoid duplicated translation
  work for the same menu item labels.

* Rename AccountListItem.h|.cpp to AccountListView.h|cpp to host all the
  code for List, Context, Item.
@humdingerb
Add context menu to "Scheduled Transactions" window
4c70ab5 
Since the user might expect it now that the other lists have it...
@dospuntos
Copy link
Contributor

This is a much needed feature, makes it a lot simpler to use the app. LGTM

@humdingerb humdingerb merged commit 073fd1a into HaikuArchives:master Jul 30, 2024
2 of 3 checks passed
@humdingerb humdingerb deleted the context branch July 30, 2024 14:30
@humdingerb
Copy link
Member Author

Agreed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humdingerb @dospuntos