PayeeBox and CategoryBox: use offset and byte length

when interaction with a BTextView fix #121
HaikuArchives · Oct 28, 2024 · 4cebe29 · 4cebe29
1 parent 9799d8c
commit 4cebe29
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/src/CategoryBox.cpp b/src/CategoryBox.cpp
@@ -61,6 +61,7 @@ CategoryBoxFilter::KeyFilter(const int32& key, const int32& mod)
 		TextControl()->TextView()->Delete(start, end);
 		BString string = "";
 		GetCurrentMessage()->FindString("bytes", &string);
+		int32 charLength = string.Length();
 
 		string.Prepend(TextControl()->Text());
 
@@ -69,7 +70,7 @@ CategoryBoxFilter::KeyFilter(const int32& key, const int32& mod)
 			autocomplete = string;
 
 		BMessage automsg(M_CATEGORY_AUTOCOMPLETE);
-		automsg.AddInt32("start", strlen(TextControl()->Text()) + 1);
+		automsg.AddInt32("start", strlen(TextControl()->Text()) + charLength);
 		automsg.AddString("string", autocomplete.String());
 		SendMessage(&automsg);
 	}

diff --git a/src/CheckView.cpp b/src/CheckView.cpp
@@ -162,15 +162,15 @@ CheckView::MessageReceived(BMessage* msg)
 			msg->FindInt32("start", &start);
 			msg->FindString("string", &string);
 			fPayee->SetText(string.String());
-			fPayee->TextView()->Select(start, string.CountChars());
+			fPayee->TextView()->Select(start, string.Length());
 			break;
 		}
 		case M_CATEGORY_AUTOCOMPLETE:
 		{
 			msg->FindInt32("start", &start);
 			msg->FindString("string", &string);
 			fCategory->SetText(string.String());
-			fCategory->TextView()->Select(start, string.CountChars() + 2);
+			fCategory->TextView()->Select(start, string.Length());
 			break;
 		}
 

diff --git a/src/PayeeBox.cpp b/src/PayeeBox.cpp
@@ -64,6 +64,7 @@ PayeeBoxFilter::KeyFilter(const int32& key, const int32& mod)
 		TextControl()->TextView()->Delete(start, end);
 		BString string = "";
 		GetCurrentMessage()->FindString("bytes", &string);
+		int32 charLength = string.Length();
 
 		string.Prepend(TextControl()->Text());
 
@@ -72,7 +73,7 @@ PayeeBoxFilter::KeyFilter(const int32& key, const int32& mod)
 			autocomplete = string;
 
 		BMessage automsg(M_PAYEE_AUTOCOMPLETE);
-		automsg.AddInt32("start", strlen(TextControl()->Text()) + 1);
+		automsg.AddInt32("start", strlen(TextControl()->Text()) + charLength);
 		automsg.AddString("string", autocomplete.String());
 		SendMessage(&automsg);
 	}

diff --git a/src/SplitView.cpp b/src/SplitView.cpp
@@ -308,7 +308,7 @@ SplitView::MessageReceived(BMessage* msg)
 			msg->FindInt32("start", &start);
 			msg->FindString("string", &string);
 			fPayee->SetText(string.String());
-			fPayee->TextView()->Select(start, string.CountChars());
+			fPayee->TextView()->Select(start, string.Length());
 			break;
 		}
 		case M_CATEGORY_AUTOCOMPLETE:
@@ -317,10 +317,10 @@ SplitView::MessageReceived(BMessage* msg)
 			msg->FindString("string", &string);
 			if (fSplitContainer->IsHidden()) {
 				fCategory->SetText(string.String());
-				fCategory->TextView()->Select(start, string.CountChars());
+				fCategory->TextView()->Select(start, string.Length());
 			} else {
 				fSplitCategory->SetText(string.String());
-				fSplitCategory->TextView()->Select(start, string.CountChars());
+				fSplitCategory->TextView()->Select(start, string.Length());
 			}
 			break;
 		}