-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Querying the DB for next events #128
Conversation
This commit is not complete yet. Currently, it only fetches the list from I am working on the attribute change and event removing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot to unpack. I did a first glance, but as you write, you still have to finish the work.
I do want to make clear that I will not approve a design where every individual node is going to be watched. This is not scalable. Even if it works for a little test data, you are going to run into limits if someone seriously uses the application.
I also don't really understand how this is supposed to work. There is an fEventList. You manually add things there, but you initialize it using a function in the QueryDBManager... Can you explain how it is supposed to work? What triggers changes? How will you determine what events to notify for next?
Yes, we can leave this (the attribute part) for now with a note to work on this post GSoC (as I stated in the mail)
The idea is to get the events list when the daemon is started and then node monitor the events directory to get the updates (adding/removing) which we can manually add/remove to/from the |
For issue: #122 The scope of this PR: To get the events-to-be-reminded in fEventList and manage it by adding/removing the events as per the requirement. |
For issue: #122
The scope of this PR: To get the events-to-be-reminded in
fEventList
and manage it by adding/removing the events as per the requirement.