-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving/Loading for events and GUI Changes for Calendar #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes/comments. Could you explain in the commit message/PR description what the data model is going to be like? When is a reminder set? How to change/remove a reminder?
While creating the event, the user can (if needed) set the reminder, let's say
Simply click on the event inside the Calendar. It'll open the Event Window with the Event's details in it. The reminder is also modifiable there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more notes. I see two edge cases that need to be handled:
- Entering invalid characters in the reminder time.
- Updating the event time should update the reminder time.
Now this is sorted by TextView()'s
This already is being handled. If the user changes the event's start time from the Calendar, the Reminder time changes as well. |
I did some testing and I found two issues. The first I want you to fix as part of this commit. The second you can create a ticket for to solve later.
|
This issue is now fixed.
I'll open an issue for this, and also mention this issue in the wrap-up blog post. |
For issue: #122
The scope of this PR: Get the events to be saved with the Reminder as per the user's requirement
The GUI looks like this: