Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT Authentication - Log in #6

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

nicoquiroga90
Copy link
Collaborator

First version of team/code authentication with added JWT. Also, the route to the dashboard page is included.
Upon entering the code, validation is performed, and if correct, access to the Dashboard is granted (which is currently empty). The idea is to later utilize this session information to display relevant information for the corresponding team.

@nicoquiroga90 nicoquiroga90 requested a review from a team as a code owner March 25, 2024 18:45
"react-scripts": "5.0.1",
"web-vitals": "^2.1.4"
},
"scripts": {
"start-server": "node src/backend/server.js",
"start-frontend": "react-scripts start --port 3003",
"start": "npm run start-server & npm run start-frontend",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for removing this? maybe we should update the readme for startup approach

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried to unify the frontend and the backend start and make it run in different ports, but talking with other of the mentors we decided to keep it separate

"start-server": "node src/backend/server.js",
"start-frontend": "react-scripts start "

Copy link

@aina21 aina21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there's some overlap in the changes between your two PRs, which could lead to merge conflicts. It might be better to just have one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants