-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWT Authentication - Log in #6
base: main
Are you sure you want to change the base?
Conversation
"react-scripts": "5.0.1", | ||
"web-vitals": "^2.1.4" | ||
}, | ||
"scripts": { | ||
"start-server": "node src/backend/server.js", | ||
"start-frontend": "react-scripts start --port 3003", | ||
"start": "npm run start-server & npm run start-frontend", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a specific reason for removing this? maybe we should update the readme for startup approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tried to unify the frontend and the backend start and make it run in different ports, but talking with other of the mentors we decided to keep it separate
"start-server": "node src/backend/server.js",
"start-frontend": "react-scripts start "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed there's some overlap in the changes between your two PRs, which could lead to merge conflicts. It might be better to just have one PR.
First version of team/code authentication with added JWT. Also, the route to the dashboard page is included.
Upon entering the code, validation is performed, and if correct, access to the Dashboard is granted (which is currently empty). The idea is to later utilize this session information to display relevant information for the corresponding team.