Javascript javascript1 week4/guzide #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly branched out from week3
Khandohii
approved these changes
Dec 12, 2024
| } | ||
|
|
||
| function setTimer(input) { | ||
| const time = input.match(/Set a timer for (\d+) minutes/i); |
There was a problem hiding this comment.
What if to set timer for "1 minute". I would add a validation for "minute" as well.
There was a problem hiding this comment.
Validation is added, thank you :)
Comment on lines
+104
to
+123
| function calculate(input) { | ||
| const numbers = input.match(/\d+/g).map(Number); | ||
| const operators = input.match(/[\+\-\*\/]/)?.[0]; | ||
| if (numbers?.length === 2 && operators) { | ||
| const [a, b] = numbers; | ||
| switch (operators) { | ||
| case "+": | ||
| return a + b; | ||
| case "-": | ||
| return a - b; | ||
| case "*": | ||
| return a * b; | ||
| case "/": | ||
| return b !== 0 ? a / b : "Cannot divide by zero"; | ||
| default: | ||
| return "Sorry, this operator is not supported."; | ||
| } | ||
| } | ||
| return "Error! Invalid calculation command."; | ||
| } |
There was a problem hiding this comment.
Good solution. For solving mathematical calculations you can use eval() function as well.
There was a problem hiding this comment.
Hi Khandohii, thank you. But while I was searching for the methods to be used I came up with this info "eval() executes any JavaScript code in the input string. This makes it vulnerable to injection attacks." That is why I did not use it. What do you think about this info?
|
Overall, thanks for the review and the constructive feedbacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the challenging exercise, huh.
Moved the week4 practice to a new branch from main which was mistakenly branched out from week3.
So I am creating the request again :)