VoiceAssistent execise #119
Conversation
|
|
||
| // Todos Part | ||
| if (command.startsWith("Add") && command.endsWith("to my todo")) { | ||
| const task = command.replace("Add ", "").replace(" to my todo", ""); |
There was a problem hiding this comment.
What happens if the thing that the user wants to add to their todo list includes the text "Add "?
| if (command.startsWith("Remove") && command.endsWith("from my todo")) { | ||
| const task = command.replace("Remove ", "").replace(" from my todo", ""); | ||
| const index = todos.indexOf(task); | ||
| if (index > -1) { |
| if (command === "What day is today?") { | ||
| const today = new Date(); | ||
| const day = today.getDate(); | ||
| const month = today.toLocaleString("en-US", { month: "long" }); |
There was a problem hiding this comment.
Good use of .toLocaleString(), but we might be able to save ourselves some further effort by using it for the day and year as well!
Also, for real apps we should consider whether en-US is the correct choice of culture. If the rest of your app is in English, then perhaps just en without a country code is preferable. If your app is localised such that users see their native language anywhere, then we might want to use default so that the date doesn't appear in English!
| num2 = parseFloat(num2); | ||
|
|
||
| if (isNaN(num1) || isNaN(num2)) { | ||
| return "I couldn't understand the numbers."; |
There was a problem hiding this comment.
Consider using an error message that gives the user more clues about how they should proceed. For example, you could help the user understand how they should be formatted, or let them know that perhaps they're missing some whitespace between the numbers and operators.
|
|
||
| function getReply(command) { | ||
| // Name Part | ||
| if (command.startsWith("Hello my name is")) { |
There was a problem hiding this comment.
What happens if the user types the command in all lower case? Would be nice if our code just handled such a situation!
No description provided.