Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last names to applicant table #268

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Lucas-Dunker
Copy link
Contributor

Add last names to HBP Application Portal Admin Table

🎫 Issue #264 .

▶ Changelist:

  • Add last names column to the admin table, with the ability to sort last names alphabetically
  • Refactor first name column to use a new index key
  • Rename column title to "First Name" instead of "Name"

📝 Notes + 🚧 TODO:

  • I found lots of weird styling quirks + some outdated components; this is an internal tool so it's not a big deal, but might be worth addressing this summer before it becomes a bigger issue later on!
  • I ran into an ERR_OSSL_EVP_UNSUPPORTED error whenever running yarn dev; a temporary fix is to run export NODE_OPTIONS=--openssl-legacy-provider before yarn dev, but a more permanent solution is updating lots of our core dependencies like node, webpack, typescript etc.

🧪 Testing:

  • Manual Testing

🎥 Screenshots & Screencasts:

image

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
application-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 0:10am

@Lucas-Dunker Lucas-Dunker added enhancement New feature or request applicants-page labels Jun 11, 2024
@Lucas-Dunker Lucas-Dunker linked an issue Jun 11, 2024 that may be closed by this pull request
Copy link
Contributor

@jmsargent10 jmsargent10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hackbeanbot hackbeanbot self-requested a review July 8, 2024 21:44
@hackbeanbot hackbeanbot removed enhancement New feature or request applicants-page labels Jul 8, 2024
@jmsargent10 jmsargent10 merged commit 056a74f into main Jul 8, 2024
3 of 4 checks passed
@jmsargent10 jmsargent10 deleted the add-last-names-to-applicant-table branch July 8, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Applicants Table Names
4 participants