Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use argparse functionality #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use argparse functionality #34

wants to merge 2 commits into from

Conversation

alexjch
Copy link

@alexjch alexjch commented Jul 26, 2024

  • Use choices for --test argument.
  • Use required for nranks, node_id arguments.

alexjch added 2 commits July 26, 2024 13:28
@alexjch
Use argparse choices mechanism
a8dc3ae 
This change makes use of argparse choices mechanism for the '--test'
argument instead of re-creating functionality.

Signed-off-by: Alex V Jaramillo <[email protected]>
@alexjch
Use argparse required argument
1d46098 
This change marks nranks and node_id arguments as required to use
the argparse argument validation instead of re-create the functinality
in code.

The original validation was left in place, because it is still required
since these values should not be negative.

Signed-off-by: Alex V Jaramillo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexjch