Use composer.json and autoload #4
Conversation
trbsi
force-pushed
the
composer-json-autoload
branch
from
813dff3 to
4f9e49c
Compare
| 'bi_tag', | ||
| 'fast_app_target', | ||
| 'biTag', | ||
| 'fastAppTarget', |
There was a problem hiding this comment.
For the reviewer: Does this has to be "fast_app_target" or it can be "fastAppTarget"
I replaced "_" in every buildFields() method
|
@HMSPushKit @Mike-mei @rmibelgium Can anyone please review this PR? |
|
Hello @trbsi |
|
@Mike-mei |
| @@ -0,0 +1,26 @@ | |||
| { | |||
There was a problem hiding this comment.
not used this php architecture since 3rd attribute
| @@ -0,0 +1,19 @@ | |||
| { | |||
| "php": ">=7.0" | ||
| }, | ||
| "platform-dev": [] | ||
| } |
| @@ -0,0 +1,151 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Example/test_sample_push_topic_msg.php has it，not need it
| use push_admin\PushLogConfig; | ||
| namespace Huawei\Example\PushCommon; | ||
|
|
||
| use Huawei\PushNotifications\PushAdmin\AndroidConfigDeliveryPriority; |
There was a problem hiding this comment.
Where is “Huawei” Directory？
| @@ -18,19 +18,14 @@ | |||
| /** | |||
| * function: webpush message push control parameter, which is required for webpush msg=>PushMessage(webpush) | |||
| */ | |||
| namespace push_admin\push_msg\webpush; | |||
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
| @@ -19,35 +19,31 @@ | |||
| * function: WebPush Headers class =>WebPushConfig(headers) | |||
| * =>PushMessage(webpush) | |||
| */ | |||
| namespace push_admin\push_msg\webpush; | |||
| namespace Huawei\PushNotifications\PushAdmin\PushMessage\WebPush; | |||
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
| @@ -19,33 +19,30 @@ | |||
| * function: WebPushHmsOptions class =>WebPushConfig(hms_options) | |||
| * =>PushMessage(webpush) | |||
| */ | |||
| namespace push_admin\push_msg\webpush; | |||
|
|
|||
| namespace Huawei\PushNotifications\PushAdmin\PushMessage\WebPush; | |||
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
| @@ -19,93 +19,114 @@ | |||
| * function: WebPushNotification class =>WebPushConfig(notification) | |||
| * =>PushMessage(webpush) | |||
| */ | |||
| namespace push_admin\push_msg\webpush; | |||
| namespace Huawei\PushNotifications\PushAdmin\PushMessage\WebPush; | |||
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
| private $title; | ||
|
|
||
| private $icon; |
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
No description provided.