Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateFaq functionality and Integrate it with Backend #983

Merged
merged 2 commits into from
May 31, 2024
Merged

updateFaq functionality and Integrate it with Backend #983

merged 2 commits into from
May 31, 2024

Conversation

shivamgaur99
Copy link
Contributor

@shivamgaur99 shivamgaur99 commented May 28, 2024 •
edited
Loading

Closes: #974

Feature Added: Update FAQ Functionality
added open dialogue for edit faq
add validations
check responsiveness in multiple devices

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

image

image

@auto-assign auto-assign bot requested a review from Kajol-Kumari May 28, 2024 14:44
Kajol-Kumari
Kajol-Kumari requested changes May 28, 2024
View reviewed changes
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, please incorporate it

frontend/src/pages/Admin/Components/Faq/ManageFaq/ManageFaq.jsx Outdated
@@ -20,19 +20,27 @@ export function ManageFaq() {
const [toastMessage, setToastMessage] = useState("");
const [severity, setSeverity] = useState("success");
const [reload, setReload] = useState(true);
const [editedFaq, setEditedFaq] = useState(null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to maintain the state for each of the fields? can we maintain the state of the faqObject? it would be much cleaner that way

Copy link
Contributor Author

@shivamgaur99 shivamgaur99 May 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done, please review

@shivamgaur99
Copy link
Contributor Author

shivamgaur99 commented May 29, 2024 •
edited
Loading

@Kajol-Kumari is it okay or we need to do same with toast ? , I've made some adjustments. Now, when users click the 'edit' button edit operation can be perform :

  1. In Accordion itself: allowing users to edit FAQs directly within the context of the FAQ list.
  2. OPEN DIALOGUE: (earlier) you can see in pull request

image

PLEASE SELECT ONE

image

image

@Kajol-Kumari
Copy link
Member

@shivamgaur99 opening the popup with form kind of look for editing looks more standard, so please stick with the same

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels May 31, 2024
@Kajol-Kumari Kajol-Kumari merged commit 5dbac86 into HITK-TECH-Community:main May 31, 2024
7 checks passed
@shivamgaur99 shivamgaur99 deleted the fix/issue-974 branch May 31, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kajol-Kumari Kajol-Kumari Kajol-Kumari approved these changes

Assignees

@shivamgaur99 shivamgaur99

Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend] [Backend] Add updateFaq functionality and Integrate it with Backend
2 participants
@shivamgaur99 @Kajol-Kumari