Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] The Broadcast isn't appearing in correct format Fixed #956

Merged
merged 3 commits into from
May 24, 2024

Conversation

Hemu21
Copy link
Contributor

@Hemu21 Hemu21 commented May 23, 2024

Issue that this pull request solves

Issue Link resolve #946
Closes: #946

Brief description of what is fixed or changed

  • The broadcast description should have appeared in formatted view, instead i am seeing html tags in it. Fixed now it appears in formatted view.
  • The link button on the details page doesn't take to the linked page Fixed. Now it redirects to the linked page.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

@auto-assign auto-assign bot requested a review from Kajol-Kumari May 23, 2024 10:08
@Hemu21
Copy link
Contributor Author

Hemu21 commented May 23, 2024

@Kajol-Kumari when you get a free time, can you please check and merge it.

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-23 at 6 06 27 PM The card is still showing unformatted data and link button is still not opening the link value coming in broadcast detail

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 23, 2024

kajolcheck
@Kajol-Kumari please check the preview deploy here. I think you checking in main website.

@Kajol-Kumari
Copy link
Member

@Hemu21 check the all broadcasts page once

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 24, 2024

@Kajol-Kumari sorry i checked only boardcasts page i doesn't checked all boardcast page. now updated can you please check.

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels May 24, 2024
@Kajol-Kumari Kajol-Kumari merged commit f0a7bd7 into HITK-TECH-Community:main May 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] The Broadcast isn't appearing in correct format
2 participants