[Backend] Integrate Delete Faq with Backend #679 #945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/src/pages/Admin/Components/Faq/ManageFaq/ManageFaq.jsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/Admin/Components/Faq/ManageFaq/manage-faq.module.scss
Outdated
Show resolved
Hide resolved
| setIsFetching(true); | ||
| const url = `${END_POINT}/deleteFaq`; | ||
| const body = { | ||
| userId: props.adminData._id, |
There was a problem hiding this comment.
delete api expecting adminId in body is wrong, @SwayamRana808 can you fixx https://github.com/HITK-TECH-Community/Community-Website/blob/main/backend/app/routes/faq/deleteFaq.js api using #933 as reference, you can create a separate issue for the same. Till then we will keep this pr on hold
There was a problem hiding this comment.
So i should remove adminId and add authmiddleware right? issue @Kajol-Kumari
There was a problem hiding this comment.
yes correct @SwayamRana808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
[Backend] Integrate Delete Faq with Backend #679
Closes: #679
Proposed changes
Integrated Delete Faq with Backend in Admin manageFAQ
Brief description of what is fixed or changed
Integrated Delete Faq with Backend in Admin manageFAQ
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request
I have removed LINK from Faq.jsx as Link as generating warning of "to" not defined as and it also makes the accordian freeze after going to manageFaq page. Removing LINK solved that problem