-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Add Q&A section in admin panel #901
Conversation
@Kajol-Kumari can you please check my pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the requested changes along with below ones -
- The title of this right panel should be
Questions & Answers
- The delete and approve buttons should appear in the card in place of
Manage Q&A
(both button horizontally aligned, you can take reference from below attached screenshot)
- I don't see the answers being fetched in here. Each questions should show the list of answers when clicked on
answers
and each of those answers should also have delete and approve buttons
frontend/src/pages/Admin/Components/Faq/Q&A/ManageQ&A/ManageQ&A.jsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/Admin/Components/Faq/Q&A/ManageQ&A/ManageQ&A.jsx
Outdated
Show resolved
Hide resolved
@Kajol-Kumari I already mentioned you about the backend problem If you click on the manage Q&A then you will get. error Why because code is not merged for backend. I hope you get my point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kajol-Kumari can you please check and merge it.
@Kajol-Kumari if we do like that then website will be slow why because we are fetching all questions at once. to achive the thing you asked. we have to fetch all the questions and then loop all questions and get all questionbyid and get answerby id. I will leads to complete slow down of website. once thing website performace also important. I made ui as you expect with website performance. please click on manage Q&A. then you will understand. |
@Hemu21 incorporate Also, the number of questions and answers won't be that much as it is rn, as currently its just test dats, so please do the requested change. Also, i don't see any loader, while the data is getting fetched, please don't forget to add that as well Also, note that the approve and delete should be present for each question and answer |
@Kajol-Kumari ok done |
@Kajol-Kumari Can you please check I made it as per your wish. Note: I already Intimated you about the website slowness. Don't blame me if website loads too slow. And important thing is please check you network connect while testing. If data doesn't load because of slow data please check your connection. previously it took seconds now it takes mins. |
Hey @Hemu21 the getanswer call is giving error. So can we do something like below -
fetch all the questions as soon as i go to |
@Kajol-Kumari I updated this. can you please check. I had already answered you regarding get answers not working Here that getanswer was i fixed in this issue itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the requested changes. LGTM 👍
Issue that this pull request solves
Issue Link resolve #888
Closes: #888
Brief description of what is fixed or changed
I created the manage Q&A for admin.
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply