Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit button in Q&A page corrected #898

Merged
merged 1 commit into from
May 16, 2024

Conversation

SwayamRana808
Copy link
Contributor

@SwayamRana808 SwayamRana808 commented May 16, 2024

Issue that this pull request solves

submit button in Q&A page corrected
Closes: #700

Proposed changes

submit button responsive .
and correct the toast. Q&A showing submitted toast even it is not -like when we enter characters less then 5 it still shows toast submitted.

Brief description of what is fixed or changed

submit button responsive earlier data loader was taking space now if submit is clicked data loader will come in place of submit button
and if response contains errStack then error toast will be shown

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

submit button responsive
331139491-4d78664f-507c-4463-b395-508a73fe8e38
331140342-94a5bbae-02a3-42bf-b2f3-472c582ca032
error msg
331140453-67acb80e-a227-46f1-8e67-ef5e8bae611c

Other information

Any other information that is important to this pull request

@auto-assign auto-assign bot requested a review from jackfrost13 May 16, 2024 10:08
@Kajol-Kumari Kajol-Kumari removed the request for review from jackfrost13 May 16, 2024 17:34
@Kajol-Kumari Kajol-Kumari added level1 Wiki or Major Documentation work. gssoc GSSoC'24 Label labels May 16, 2024
@Kajol-Kumari Kajol-Kumari merged commit 98bcd3d into HITK-TECH-Community:main May 16, 2024
7 checks passed
@SwayamRana808 SwayamRana808 deleted the Submitbtn branch May 31, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level1 Wiki or Major Documentation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Make Q&A Page
2 participants