Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix backend addteammembers api is Fixed #876

Merged
merged 12 commits into from
May 15, 2024

Conversation

Hemu21
Copy link
Contributor

@Hemu21 Hemu21 commented May 13, 2024

Issue that this pull request solves

There is problem with addTeamMembers api. Because it frontend is unable to add team members and throwing errors. fixing it is most important to fix frontend problems. By merging this pr. Backend is add team member endpoint is ready for Frontend development.

Issue

Issue Link resolve #872
Closes: #872

Brief description of what is fixed or changed

I fixed the addteammembers endpoint file in backend. It has a function that function is wrong I corrected it.

How to test it

  • Way one

Check for the below thing in db. why because I added it.

{ description:"This is for checking the api", full_name: "testing", teams: ["Aman","anubhav"], __v: 0, _id: "664251826c3bb95cd441ebd9" }

  • way 2
    try to add team members form this api.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 14, 2024

@Kajol-Kumari can you please check this and merge it. then i will start working on #725

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hemu21 what exactly have you fixed in this pr? There is an issue with multer upload and al i see in this pr is just comments and payload change

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 14, 2024

@Kajol-Kumari don't merge this pr if you merge it again you will get error.

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 14, 2024

@Kajol-Kumari Now you can merge it. Now there will be no errors.

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 15, 2024

@Kajol-Kumari can you please merge it. I will start my next issue.

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hemu21 please remove those commented lines and it should be good to merge

/* eslint-disable prefer-const */
/* eslint-disable consistent-return */
/* eslint-disable no-unused-vars */
/* eslint-disable prettier/prettier */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove these un-necessary changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kajol-Kumari If i remove those 4 line while commiting the changes it askes to change the entire file.

@@ -1,3 +1,11 @@
/* eslint-disable import/newline-after-import */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[neat]please remove these un-necessary changes.

@@ -1,3 +1,11 @@
/* eslint-disable import/newline-after-import */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[neat]please remove these un-necessary changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kajol-Kumari @Kajol-Kumari If i remove those 4 line while commiting the changes it askes to change the entire file. Changing the entire file may effect other function so i added that comments. They are unnecessary. but to commit changes they are necessary other wise we have to change all those files. I hope you understand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is these lines are disabling all the linting checks and so i can't allow it to be merged. can you please raise a new pr with just those 2 required change?

@Kajol-Kumari Kajol-Kumari added level1 Wiki or Major Documentation work. gssoc GSSoC'24 Label labels May 15, 2024
@Kajol-Kumari Kajol-Kumari merged commit 941973a into HITK-TECH-Community:main May 15, 2024
7 checks passed
@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. and removed level1 Wiki or Major Documentation work. labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix backend addteammembers api
2 participants