Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin profile made dynamic successfully #865

Merged
merged 2 commits into from
May 13, 2024

Conversation

Mandar007007
Copy link
Contributor

@Mandar007007 Mandar007007 commented May 12, 2024

Issue that this pull request solves

Closes: #467

Proposed changes

  1. made dynamic name of admin instead of Welcome Admin! hardcoded value
  2. made dynamic profile section

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Uploading Screenshot (158).png…

Copy link

welcome bot commented May 12, 2024

Thank you and congrats🎉 for opening this pull request!💖

Please make sure you have followed our Contributing Guidelines.🙌 We will test out your code and reply in a bit with some pointers and requests.💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 If you haven't filled the template out, Please do so!🚀
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@auto-assign auto-assign bot requested a review from Kajol-Kumari May 12, 2024 13:14
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mandar007007 the build is failing, can you please fix it. Also, the attached video/scree shot of how it will look after this change will make it easier for the review

@Mandar007007
Copy link
Contributor Author

all the testcases are now passing now it should work perfectly

@Mandar007007
Copy link
Contributor Author

please check the changes now. it is working correctly...
Screenshot (158)

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The api for getting the loggedIn admin detail isn't ready yet, so i am accepting this pr after reducing its difficulty level.

@Kajol-Kumari Kajol-Kumari merged commit 1e6fd02 into HITK-TECH-Community:main May 13, 2024
6 checks passed
Copy link

welcome bot commented May 13, 2024

Congrats on merging your first pull request! 🙌 🎉 ⚡️ Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step.😄🙌
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Admin Profile Dynamic
2 participants