Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] Improve the Manage Q&A UI #1105

Merged
merged 3 commits into from
Aug 5, 2024
Merged

[Frontend] Improve the Manage Q&A UI #1105

merged 3 commits into from
Aug 5, 2024

Conversation

shivamgaur99
Copy link
Contributor

@shivamgaur99 shivamgaur99 commented Aug 3, 2024 •
edited
Loading

Improve the Manage Q&A UI

Closes: #1096

image

image

@auto-assign auto-assign bot requested a review from Kajol-Kumari August 3, 2024 21:28
@shivamgaur99
Copy link
Contributor Author

shivamgaur99 commented Aug 3, 2024 •
edited
Loading

Hi @Kajol-Kumari please review everything is functional, we dont need now manageQ&A folder setTab(19) can we remove it ?

image

@Kajol-Kumari
Copy link
Member

@shivamgaur99 without manage Q&A how will admins see the list of the questions/answers? If its actually redundant code, fee free to remov eit

@shivamgaur99 shivamgaur99 marked this pull request as draft August 4, 2024 19:49
@shivamgaur99 shivamgaur99 marked this pull request as ready for review August 4, 2024 20:11
@shivamgaur99
Copy link
Contributor Author

shivamgaur99 commented Aug 4, 2024 •
edited
Loading

@Kajol-Kumari Actually We are manging Q&A in Q&A folder not in mangeQ&A folder so i removed it. it was only for manging ans in new window but now we don't require this since we are manging in same tab

Now Pr is ready for review

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels Aug 5, 2024
@Kajol-Kumari Kajol-Kumari merged commit 9b01752 into HITK-TECH-Community:main Aug 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kajol-Kumari Kajol-Kumari Kajol-Kumari approved these changes

Assignees

@shivamgaur99 shivamgaur99

Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend] Improve the Manage Q&A UI
2 participants
@shivamgaur99 @Kajol-Kumari