-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] post testimonials backend Fixed #1056
Conversation
@Kajol-Kumari can you please check and merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment
@Kajol-Kumari can you please tell what are the minor comments |
frontend/src/pages/Admin/Components/Testimonial/AddTestimonial/AddTestimonial.jsx
Show resolved
Hide resolved
}else{ | ||
formattedPath = "./images/testimonialImg.png"; | ||
} | ||
_data[index].image = formattedPath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kajol-Kumari This is the function we used to get data. here I made small chage if image exist. we use that url else we use default image a url.
@Kajol-Kumari I had made it as if user provide the image we use it and display it. if user doesn't provide then no need to save default. instead we can show them default in frontend. I check it is working. you can check in the preview you can see the default images. |
Issue that this pull request solves
Issue Link resolve #1054
Closes: #1054
Brief description of what is fixed or changed
Now testimonial image saving and display is working fine.
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply