Admin profile validation #1047
Merged
Admin profile validation #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubmission input should not get cleared if validaion is not matched and also question pop up should be closed if question is uploaded successfully fix issue HITK-TECH-Community#977
in admin profile username was not letting enter username which contain numbers or underscore and was giving the validation error now it is fixed now it take both underscore and number also fixes HITK-TECH-Community#1042
Kajol-Kumari
requested changes
Jun 15, 2024
There was a problem hiding this comment.
@ayushpatel1248 there are so many unnecessary change in this file that its hard to follow, please clean it up and only keep the required changes
| @@ -109,6 +114,7 @@ function Ques(props) { | |||
| }); | |||
| setFormErrors({}); | |||
| setCheckedState(new Array(Tags.length).fill(false)); | |||
| setButtonPressed(false); | |||
There was a problem hiding this comment.
Why is this change again coming?
|
@Kajol-Kumari removed the unnecessary changes and kept only required changes , please check it out |
Kajol-Kumari
approved these changes
Jun 16, 2024
|
@ayushpatel1248 i don' see the second part of the issue in this pr - #1042 (comment) The username should come in profile detail like explained in the referred comment |
|
@Kajol-Kumari i have updated the code now validation of username is also perfect and also username is placed in profile |
Kajol-Kumari
added
level1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
previously if we try ot update the admin profile username due to validation admin was not able to enter the numbers or _ in there validation
but now i have changed the validation and now admin can use number as well as _ in there username
Closes: #1042
Proposed changes
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Screen.Recording.2024-06-13.at.12.28.42.AM.mov