Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Backend ]Create Get Testimonial API #1035

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

shivamgaur99
Copy link
Contributor

@shivamgaur99 shivamgaur99 commented Jun 10, 2024

Closes: #1024

Get Testimonial API to fetch testimonials from the database.

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

image

@auto-assign auto-assign bot requested a review from Kajol-Kumari June 10, 2024 16:27
@shivamgaur99
Copy link
Contributor Author

@Kajol-Kumari please review and let me know if any changes required

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels Jun 10, 2024
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Kajol-Kumari Kajol-Kumari merged commit ce35ae3 into HITK-TECH-Community:main Jun 10, 2024
7 checks passed
@shivamgaur99
Copy link
Contributor Author

@Kajol-Kumari Can I create separate issues for the POST, UPDATE, and DELETE APIs in the backend?

@Kajol-Kumari
Copy link
Member

@shivamgaur99 Testimonials can be directly entered by admins so create and delete API will be required and will be good to be integrated on the admin panel.

@shivamgaur99
Copy link
Contributor Author

@Kajol-Kumari Can I create the issue ?

@Kajol-Kumari
Copy link
Member

yes, for create and delete please feel free to create, also we will need frontend issues for integrating it to admin dashboard, i will create them if you don't get time

@shivamgaur99
Copy link
Contributor Author

also we will need frontend issues for integrating it to admin dashboard, i will create them if you don't get time

@Kajol-Kumari could you please open frontend issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Create Get Testimonial API
2 participants