Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing N-dimensional histogram entry ordering #248

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

yimuchen
Copy link
Contributor

@yimuchen yimuchen commented Feb 9, 2024

  • Fixing histogram order.
    • Adding example to example notebook for user inspection
  • Fixing python styling issues according to flake8

📚 Documentation preview 📚: https://hepdata-lib--248.org.readthedocs.build/en/248/

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ed9148) 87.71% compared to head (2bcc68b) 87.70%.

Files Patch % Lines
hepdata_lib/hist_utils.py 80.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   87.71%   87.70%   -0.02%     
==========================================
  Files           5        5              
  Lines        1083     1082       -1     
  Branches      231      231              
==========================================
- Hits          950      949       -1     
  Misses         93       93              
  Partials       40       40              
Flag Coverage Δ
unittests-3.10 87.70% <80.00%> (-0.02%) ⬇️
unittests-3.6 87.39% <80.00%> (-0.02%) ⬇️
unittests-3.7 87.39% <80.00%> (-0.02%) ⬇️
unittests-3.8 87.52% <80.00%> (-0.02%) ⬇️
unittests-3.9 87.52% <80.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@clelange clelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

hepdata_lib/hist_utils.py Show resolved Hide resolved
@clelange clelange merged commit ed14390 into HEPData:main Feb 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants