JSON Escape group and dataset names #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
force-pushed
the
encode_test_fix
branch
from
4275450 to
729afef
Compare
jhendersonHDF
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RV_group_createandRV_dataset_createsend the name of the new group/dataset as JSON in the POST body. If the name contained a legal HDF5 name character that is a control character in JSON (e.g.\), the group/dataset would be created with an incorrect name. Now, a helper function encodes the name before adding it to the request body.This is tested by
test_url_encodingintest_rest_vol.c. With versions of HSDS before HDFGroup/hsds#296, HSDS erroneously truncates the nameurl_encoding_group !*'():@&=+$,?#[]-.<>\^`{}|~tourl_encoding_group !*'():@&=+$,, so the behavior with the JSON control character\was not being tested.