Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for quick start usage #373

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fixes for quick start usage #373

merged 1 commit into from
Jun 17, 2024

Conversation

jreadey
Copy link
Member

@jreadey jreadey commented Jun 11, 2024

Updates so quickstart instructions work

@jreadey jreadey requested a review from mattjala June 11, 2024 15:20
mattjala
mattjala previously approved these changes Jun 11, 2024
Copy link
Contributor

@mattjala mattjala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test failure is due to a 409 conflict trying to create a dataset during a test on Windows. I suspect it's another result of two domains having the same name due to low timestamp resolution - either way, nothing related to this set of changes.

@mattjala mattjala dismissed their stale review June 12, 2024 16:39

Overlap in changeset

@mattjala
Copy link
Contributor

It looks like these changes are also included in #372. They should either be dropped from that PR, or this should be closed

@jreadey
Copy link
Member Author

jreadey commented Jun 12, 2024

#372 was created in error - I've closed that.

@jreadey jreadey merged commit 80158bb into master Jun 17, 2024
42 of 43 checks passed
@jreadey jreadey deleted the quickstart2 branch June 17, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants